aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D158558#4613139 <https://reviews.llvm.org/D158558#4613139>, @serge-sans-paille wrote: > I don't have a strong opinion on the synchronization with `TextNodeDumper`. > I'm pretty sure I didn't update it while adding fields for the Attribute > nodes though... We usually try to keep them marginally in sync with one another (they're both intended debugging aids, so if you need the info in one form, it's plausible you'd need it in the other as well), but there's no hard requirement given that they're debugging aids. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158558/new/ https://reviews.llvm.org/D158558 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits