cor3ntin added inline comments.
================ Comment at: clang/lib/Sema/SemaOverload.cpp:13033 + ExprResult Res = FixOverloadedFunctionReference(E, DAP, Found); + if (Res.isInvalid()) + return false; ---------------- aaron.ballman wrote: > Below you assume that `Res.get()` returns a nonnull pointer, so you need to > check for usable instead of valid. Probably worth a pass over the other uses > of `isInvalid()` to see if maybe `!isUsable()` is better. I don't think `FixOverloadedFunctionReference` can ever be null, and if it can, maybe it's better to let it assert so that we know we missed something, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140828/new/ https://reviews.llvm.org/D140828 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
