bogner added inline comments.
================ Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:30 // expected-error@+1 {{'shader' attribute parameters do not match the previous declaration}} +[shader("pixel")] ---------------- bob80905 wrote: > I don't think we should expect this error, given that there is no previous > declaration for doubledUp(). Maybe something else like %0 and %1 are > incompatible attributes? I don't necessarily disagree, but if we're going to change that I think it should be in a different change than this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158820/new/ https://reviews.llvm.org/D158820 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits