xgupta added a subscriber: rsmith. xgupta added a comment. Just address @rsmith, I think after that we are fine to commit this review.
> + "%sub{select_special_member_kind}0 cannot be 'constexpr' in a class or > struct with virtual base classes">; Please don't say "class or struct" here. Either just say "class" (a struct is a kind of class) or actually figure out which one it is and say that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits