shafik added inline comments.
================ Comment at: clang/include/clang/AST/DeclCXX.h:2174 + static QualType getThisType(const FunctionProtoType *FPT, ---------------- cor3ntin wrote: > Whitespace only change Spurious change. ================ Comment at: clang/lib/Sema/SemaExprMember.cpp:1903-1906 /*OpLoc*/ SourceLocation(), - /*IsArrow*/ true, + /*IsArrow*/ !getLangOpts().HLSL, SS, TemplateKWLoc, /*FirstQualifierInScope*/ nullptr, ---------------- To be consistent with [bugprone-argument-comment](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html) ================ Comment at: clang/lib/Sema/SemaTemplate.cpp:763-765 + Context, /*This*/ nullptr, ThisType, + /*IsArrow*/ !Context.getLangOpts().HLSL, /*Op*/ SourceLocation(), SS.getWithLocInContext(Context), TemplateKWLoc, ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159247/new/ https://reviews.llvm.org/D159247 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits