smeenai added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3108
+    SmallString<128> TargetDir(Path);
+    llvm::sys::path::append(TargetDir, Target, "c++", Version);
     if (D.getVFS().exists(TargetDir))
----------------
rprichard wrote:
> Will the `Target` here have an Android API level suffix?
> 
Yup, it will. D159293 and D158476 are the follow-ups to address that. The first 
one makes this call-site use the current fallback logic in the driver, and the 
second one extends that fallback logic to look for the next newest available 
API level if you don't have headers/libraries for the current API level.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159292/new/

https://reviews.llvm.org/D159292

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to