ro marked an inline comment as done. ro added inline comments.
================ Comment at: clang/test/CodeGen/dwarf-version.c:7 // RUN: %clang -target x86_64-linux-gnu -gdwarf -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER5 +// RUN: %clang -target i386-pc-solaris -g -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER5 +// RUN: %clang -target i386-pc-solaris -gdwarf -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER5 ---------------- MaskRay wrote: > Switch to `--target=` while moving lines. Two questions: - Wouldn't it be better to keep the style consistent across a file, rather than introduce a mix? - I guess it's ok to just commit the patch with such a slight revision without re-uploading it to Phabricator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159352/new/ https://reviews.llvm.org/D159352 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
