brad added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:24-25 + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/lib")); + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/develop/lib")); } ---------------- trungnt2910 wrote: > Should we also add the corresponding non-packaged paths, like > `/boot/system/non-packaged/lib` and `/boot/system/non-packaged/develop/lib`? > > The latest GCC toolchain on Haiku does **not** do it, but neither does it > recognize non-packaged files for the headers. > Should we also add the corresponding non-packaged paths, like > `/boot/system/non-packaged/lib` and `/boot/system/non-packaged/develop/lib`? > > The latest GCC toolchain on Haiku does **not** do it, but neither does it > recognize non-packaged files for the headers. The second path does not exist and the first path has some sub-dirs (Perl / Python) but does not have any libraries. I'm using what the LLVM patches had. I think we're good as is as a start. ================ Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:24-25 + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/lib")); + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/develop/lib")); } ---------------- brad wrote: > trungnt2910 wrote: > > Should we also add the corresponding non-packaged paths, like > > `/boot/system/non-packaged/lib` and `/boot/system/non-packaged/develop/lib`? > > > > The latest GCC toolchain on Haiku does **not** do it, but neither does it > > recognize non-packaged files for the headers. > > Should we also add the corresponding non-packaged paths, like > > `/boot/system/non-packaged/lib` and `/boot/system/non-packaged/develop/lib`? > > > > The latest GCC toolchain on Haiku does **not** do it, but neither does it > > recognize non-packaged files for the headers. > > The second path does not exist and the first path has some sub-dirs (Perl / > Python) but does not have any libraries. > > I'm using what the LLVM patches had. I think we're good as is as a start. > Should we also add the corresponding non-packaged paths, like > `/boot/system/non-packaged/lib` and `/boot/system/non-packaged/develop/lib`? > > The latest GCC toolchain on Haiku does **not** do it, but neither does it > recognize non-packaged files for the headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
