iana marked an inline comment as done. iana added a comment. In D159483#4641289 <https://reviews.llvm.org/D159483#4641289>, @benlangmuir wrote:
>>> How does this work today? Wouldn't the include guard prevent this? >> >> Today they don't define their include guard when building with modules. > > Thanks - I can see some headers behave that way, or in other cases there are > other sorts of has_feature(modules) checks that I can see you're modifying, > but what about all the *va_* headers that currently just seem to have normal > header guards? I think the stdarg ones didn't always work properly in modules and we just got lucky. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159483/new/ https://reviews.llvm.org/D159483 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
