[clang] [sema] Improve -Wsign-compare (PR #65684)

[Shafik Yaghmour via cfe-commits]

================
@@ -14135,8 +14164,8 @@ static void AnalyzeComparison(Sema &S, BinaryOperator 
*E) {
 
   // Go ahead and analyze implicit conversions in the operands.  Note
   // that we skip the implicit conversions on both sides.
-  AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
-  AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
+  AnalyzeImplicitConversions(LHS, E->getOperatorLoc(), false, false);
+  AnalyzeImplicitConversions(RHS, E->getOperatorLoc(), false, false);
----------------
shafik wrote:

```suggestion
  AnalyzeImplicitConversions(LHS, E->getOperatorLoc(), /*IsInitList=*/false, 
/*IsTopLevelExpr=*/false);
  AnalyzeImplicitConversions(RHS, E->getOperatorLoc(), /*IsInitList=*/false, 
/*IsTopLevelExpr=*/false);
```

https://github.com/llvm/llvm-project/pull/65684
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits