compnerd added inline comments. ================ Comment at: include/__config:559 @@ -554,1 +558,3 @@ +# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS +# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS #endif ---------------- Does it make sense for `_LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS` to ever be marked as `__declspec(dllimport)`? The macro is applied on instantiations in the implementation, not the header, so this shouldn't be visible to users.
https://reviews.llvm.org/D24679 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
