[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

[Justin Bogner via Phabricator via cfe-commits]

bogner added a subscriber: Keenuts.
bogner added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4146
   if (Opts.HLSL) {
-    bool SupportedTarget = (T.getArch() == llvm::Triple::dxil ||
-                            T.getArch() == llvm::Triple::spirv) &&
-                           T.getOS() == llvm::Triple::ShaderModel;
-    if (!SupportedTarget)
+    if (T.isDXIL() || T.isSPIRV) {
+      enum { ShaderModel, ShaderStage };
----------------
@Keenuts Does this look right, or do we want something like `T.isSPIRVLogical` 
here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159103/new/

https://reviews.llvm.org/D159103

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits