iana requested changes to this revision. iana added a comment. This revision now requires changes to proceed.
I was talking to Ben about this one a little today since I ended up needing to make the same `-isystem`/`-I` -> `-internal-isystem` switch in some of the unit tests in D159064 <https://reviews.llvm.org/D159064>. I think it's just plain not supported to put isysroot/usr/include before resource-dir/include. That said, fusing resource-dir/include/inttypes.h with isysroot/usr/include is probably going to break the projects that messed that up, whereas having the two in different modules probably won't. So even though this change is correct, IMO it's not worth the trouble since we have to do D159064 <https://reviews.llvm.org/D159064> to make the libc++ cstd header work anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158021/new/ https://reviews.llvm.org/D158021 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
