tbaeder added a comment. In D158472#4605228 <https://reviews.llvm.org/D158472#4605228>, @hazohelet wrote:
> This breaks the one-note-for-one-overload-candidate rule of overload > resolution failure diagnostics > (https://github.com/llvm/llvm-project/blob/ff08c8e57e39d7970b65637595cdc221901f4ed1/clang/lib/Sema/SemaOverload.cpp#L11517-L11526), > but in most cases this change would produce less lines of diagnostics. > If we don't like this additional note, we could instead suppress the fix-it > diagnostics when the fix-it location and the diagnosed candidate location are > not close (for example, more than 2 lines away). IIRC @aaron.ballman usually has an opinion on rules like that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158472/new/ https://reviews.llvm.org/D158472 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
