owenpan added inline comments. Herald added a reviewer: rymiel.
================ Comment at: clang/include/clang/Format/Format.h:3555 AfterFunctionDefinitionName(false), AfterIfMacros(false), - AfterOverloadedOperator(false), AfterRequiresInClause(false), - AfterRequiresInExpression(false), BeforeNonEmptyParentheses(false) {} + AfterOverloadedOperator(false), AfterPlacementOperator(APO_Leave), + AfterRequiresInClause(false), AfterRequiresInExpression(false), ---------------- omarahmed wrote: > HazardyKnusperkeks wrote: > > We change the behavior here, I'm still not convinced we should do that. > > Although I'm a big supporter of the `Leave` option. > I am neutral to both cases, so I leave the choice to you as I am not > experienced with clang-format users. Let me know which choice you think would > be better. > We change the behavior here, I'm still not convinced we should do that. > Although I'm a big supporter of the `Leave` option. @HazardyKnusperkeks should we merge this patch as is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits