hokein added a comment.
The interfaces look good to me roughly.
================
Comment at: migrate-tool/MigrationEnvironment.h:22
@@ +21,3 @@
+// RefactoringManager, and AffectedFilesFinder.
+class MigrationEnvironment {
+public:
----------------
`MigrationContext` might be better?
================
Comment at: migrate-tool/MigrationEnvironment.h:24
@@ +23,3 @@
+public:
+ MigrationEnvironment() = delete;
+ // Creates a migration environement containing codebase-dependent component.
----------------
This is not needed IMO since you have defined a four-parameters constructor
below, compiler won't generate the default constructor implicitly.
https://reviews.llvm.org/D24380
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
