================ @@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) { TEST(TargetParserTest, ARMPrintSupportedExtensions) { std::string expected = "All available -march extensions for ARM\n\n" - "\tcrc\n\tcrypto\n\tsha2"; + " Name Description\n" + " crc This is a long dummy description\n" + " crypto This is a long dummy description\n" + " sha2 This is a long dummy description\n"; + + llvm::StringMap<llvm::StringRef> DummyMap; + for (const auto &E : llvm::ARM::ARCHExtNames) + DummyMap.insert({E.Name, "This is a long dummy description"}); ---------------- DavidSpickett wrote:
The harm is we aren't testing what happens if an extension has no description. If the underlying implementation changes in the future to something that does fault on a missing description, no one will know until a user tries the option. https://github.com/llvm/llvm-project/pull/66715 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits