ioeric added inline comments. ================ Comment at: lib/Tooling/Core/Replacement.cpp:179-181 @@ +178,5 @@ +llvm::Expected<Replacements> +Replacements::mergeIfOrderIndependent(const Replacement &R) const { + Replacements Rs(R); + Replacements RsShiftedByReplaces(getReplacementInChangedCode(R)); + Replacements ReplacesShiftedByRs; ---------------- klimek wrote: > I think this is a bit subtle and needs a lot more comments to guide me along > what is happening and why ... Ahh, right! Should've done that...
Comments added. https://reviews.llvm.org/D24800 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits