tarunprabhu wrote:

Thanks @DavidTruby. 

For this particular patch, the main concern is how the compiler flags are 
mapped to the corresponding linker flags on Windows. All of that work is done 
by clang, and I haven't touched any of it so I am not worried about 
correctness. 

The two main concerns are:

1) What are the linker flags in Windows corresponding to -static and -shared on 
*nix. 
2) Do the checks in the test need to be expanded to account for different 
linkers on Windows.



https://github.com/llvm/llvm-project/pull/66702
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to