erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land.
2 nits on the CFE, else LGTM! Obviously you still need an LLVM reviewer for the backend changes. ================ Comment at: clang/lib/CodeGen/CGExpr.cpp:3701 + QualType PointeeType = E->getType()->getPointeeType(); + if (PointeeType.isNull()) + return false; ---------------- We override `operator bool` to make this work. ================ Comment at: clang/lib/CodeGen/CGExpr.cpp:3703 + return false; + if (auto *BaseDecl = PointeeType->getAsRecordDecl()) + return hasBPFPreserveStaticOffset(BaseDecl); ---------------- if possible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133361/new/ https://reviews.llvm.org/D133361 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
