mizvekov wrote:

> Could you please send me a link which describes that process? I assume that 
> by MR you mean merge request? Thanks, Kirill
> […](#)
> On Mon, Oct 2, 2023 at 5:24 PM Matheus Izvekov ***@***.***> wrote: 
> @kstoimenov <https://github.com/kstoimenov> I believe you are supposed to 
> notify the MR in case of reverts, otherwise I could have missed this if I 
> wasn't awake. I believe in this case the bot is misconfigured, it's using 
> -Werror,-Wmissing-field-initializers, the 'error' is just a missing 
> initializer, which I didn't add because I think it makes the intent clearer. 
> — Reply to this email directly, view it on GitHub <[#67066 
> (comment)](https://github.com/llvm/llvm-project/pull/67066#issuecomment-1743967544)>,
>  or unsubscribe 
> <https://github.com/notifications/unsubscribe-auth/AUYQWJYIC6HAC4YEVY2CWTDX5NLMDAVCNFSM6AAAAAA5CFXAASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTHE3DONJUGQ>
>  . You are receiving this because you were mentioned.Message ID: ***@***.***>
> -- Kirill Stoimenov | Software Engineer | ***@***.*** | +1- 650-253-6893

Sure.

https://github.com/llvm/llvm-project/blob/main/llvm/docs/DeveloperPolicy.rst#id62

See specifically the section about `What are the expectations around a 
revert?`, specifically fourth bullet.

But use your best judgement here: If you revert a commit without engaging the 
original author, he might have a hard time figuring out there was even a revert.
And also, you need to engage for other reasons as described in that section.

https://github.com/llvm/llvm-project/pull/67066
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to