jrtc27 added a comment. In D157331#4653224 <https://reviews.llvm.org/D157331#4653224>, @aaron.ballman wrote:
> In D157331#4653222 <https://reviews.llvm.org/D157331#4653222>, @jrtc27 wrote: > >> One more thought: we need to specify a triple for the tests as otherwise >> it'll use whatever default you have configured in LLVM, which will affect >> the exact code generated (especially wrt argument and return lowering), no? > > Now that we're using the script (which generates a lot more CHECK lines), I > think we will have to add a triple, good catch. `x86_64-unknown-unknown` > seems like it would be a reasonable triple (but I defer to @jrtc27 if she's > got other ideas). Yeah, generally "pick your favourite x86_64 triple". In RISC-V land we generally go for a bare riscv64 as the triple for anything that's not OS-specific and just pick up whatever the bare-metal ABI is (normally close to whatever Linux and BSDs do), but historically x86_64 seems to be a bit more of a mix of everything (bare, linux-gnu, unknown-unknown, something apple-y). I'd lean towards just x86_64, but it doesn't hugely matter here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
