arphaman added a comment.
Thanks for working on this, I have a couple of comments/questions:
- The current logic doesn't work correctly for a test case that's shown below:
class C2 {
void __attribute__((unused)) m4() { }
void __attribute__((unused)) m5();
};
The method 'm4' actually gets covered with a zero region. I suspect you might
have to perform the check for the attribute in the
'EmptyCoverageMappingBuilder' class as well.
- I understand the value in ignoring coverage for unused functions which aren't
actually used anywhere. But people can still use them freely, so do you think
that it would be a good idea to provide coverage for those functions when they
are actually used?
https://reviews.llvm.org/D25040
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
