efriedma added a comment. > For assembly, I'm not really comfortable with the fix you're proposing; it > relies on the order in which functions are defined in assembly. I think LLVM > usually ends up emitting module-level inline assembly before generated code, > but it seems fragile to depend on that ordering. And the way the check is > written doesn't account for other differences in the way we normally generate > code for declarations vs. definitions, which I'm afraid might make the linker > unhappy.
Also, checking isUndefined() completely explodes if you use -fno-integrated-as, although I guess that's not common for Windows targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157547/new/ https://reviews.llvm.org/D157547 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
