https://github.com/AMS21 created https://github.com/llvm/llvm-project/pull/69045
With this patch we no longer issue a warning for unused parameters which are
marked as such.
This fixes #68209
>From 04eff97d2154edf49a21d276e3872cef0f64b654 Mon Sep 17 00:00:00 2001
From: AMS21 <ams21.git...@gmail.com>
Date: Sat, 14 Oct 2023 10:26:36 +0200
Subject: [PATCH] [clang-tidy] Ignore unused parameters in
`rvalue-reference-param-not-moved check`
With this patch we no longer issue a warning for unused parameters which
are marked as such.
This fixes #68209
---
.../RvalueReferenceParamNotMovedCheck.cpp | 3 +++
clang-tools-extra/docs/ReleaseNotes.rst | 4 ++++
.../rvalue-reference-param-not-moved.cpp | 19 +++++++++++++++++++
3 files changed, 26 insertions(+)
diff --git
a/clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp
b/clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp
index efcaffb45d9ad8a..88b00dc17470f32 100644
---
a/clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp
+++
b/clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp
@@ -84,6 +84,9 @@ void RvalueReferenceParamNotMovedCheck::check(
if (IgnoreUnnamedParams && Param->getName().empty())
return;
+ if (!Param->isUsed() && Param->hasAttr<UnusedAttr>())
+ return;
+
const auto *Function = dyn_cast<FunctionDecl>(Param->getDeclContext());
if (!Function)
return;
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst
b/clang-tools-extra/docs/ReleaseNotes.rst
index 03e5dc6f164af2a..c732d4904df13fa 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -237,6 +237,10 @@ Changes in existing checks
<clang-tidy/checks/cppcoreguidelines/pro-type-vararg>` check to ignore
false-positives in unevaluated context (e.g., ``decltype``, ``sizeof``, ...).
+- Improved :doc:`cppcoreguidelines-rvalue-reference-param-not-moved
+ <clang-tidy/checks/cppcoreguidelines/rvalue-reference-param-not-moved>` check
+ to ignore unused parameters when they are marked as unused.
+
- Improved :doc:`llvm-namespace-comment
<clang-tidy/checks/llvm/namespace-comment>` check to provide fixes for
``inline`` namespaces in the same format as :program:`clang-format`.
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp
b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp
index 8f8e272e1e8a90d..c6a70aef810ac90 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp
@@ -333,3 +333,22 @@ void instantiate_a_class_template() {
AClassTemplate<Obj&> withObjRef(o);
withObjRef.never_moves(o);
}
+
+namespace gh68209
+{
+ void f1([[maybe_unused]] int&& x) {}
+
+ void f2(__attribute__((unused)) int&& x) {}
+
+ void f3(int&& x) {}
+ // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: rvalue reference parameter 'x'
is never moved from inside the function body
[cppcoreguidelines-rvalue-reference-param-not-moved]
+
+ template <typename T>
+ void f4([[maybe_unused]] T&& x) {}
+
+ template <typename T>
+ void f5(__attribute((unused)) T&& x) {}
+
+ template<typename T>
+ void f6(T&& x) {}
+} // namespace gh68209
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
