tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1213
std::optional<PrimType> SubExprT = classify(SubExpr);
- if (E->getStorageDuration() == SD_Static) {
+ bool IsStatic = E->getStorageDuration() == SD_Static;
+ if (GlobalDecl || IsStatic) {
----------------
aaron.ballman wrote:
> Should we be looking at the TLS kind of the extended declaration?
> (`CheckCompleteVariableDeclaration()` is using `VarDecl::getTLSKind() ==
> VarDecl::TLS_Static`)
>
> Would something along these lines work instead?
> ```
> bool EmitGlobalTemp = E->getStorageDuration() == SD_Static;
> if (!EmitGlobalTemp) {
> if (const LifetimeExtendedTemporaryDecl *LETD =
> E->getLifetimeExtendedTemporaryDecl()) {
> if (const auto *VD =
> dyn_cast_if_present<VarDecl>(LETD->getExtendingDecl()) {
> EmitGlobalTemp= VD->getTLSKind() == VarDecl::TLS_Static;
> }
> }
> }
> ```
That code definitely works for the current `AST/Interp/` tests, but we don't
have tests for thread local stuff in there right now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156453/new/
https://reviews.llvm.org/D156453
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
