tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
LGTM. > DiagnosticSemaKinds.td:6727 > def err_cuda_extern_shared : Error<"__shared__ variable %0 cannot be > 'extern'">; > +def err_cuda_nonglobal_constant : Error<"__constant__ variables must be > global">; > Nit: Technically they are allowed in namespace scope. https://reviews.llvm.org/D25129 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
