tbaeder added inline comments.

================
Comment at: clang/lib/AST/Interp/Descriptor.h:203
 
+public:
   /// Initializes the map with no fields set.
----------------
aaron.ballman wrote:
> This interface is now more confusing as to how to use because it now has a 
> public non-default constructor *and* an `initialize` method. Perhaps we 
> should rename `initialize` to `initializeMapElement` so it's clear that the 
> `initialize` method isn't for the map itself?
Made more things private and renamed `initialize()` and `isInitialized()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154581/new/

https://reviews.llvm.org/D154581

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to