rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



> SemaOverload.cpp:1131
>  
>    if (getLangOpts().CUDA && ConsiderCudaAttrs) {
>      CUDAFunctionTarget NewTarget = IdentifyCUDATarget(New),

I feel like we should exit early on destructors here, before we do any target 
checks. The assert also feels kind of trivial because we only come into this 
overload machinery if looking up New's DeclarationName found Old.

https://reviews.llvm.org/D24571



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to