majnemer added inline comments.

> ItaniumMangle.cpp:1234
>  
> -      mangleSourceName(II);
> +      auto FD = dyn_cast<FunctionDecl>(ND);
> +      bool isRegCall = (FD != nullptr) &&

`auto *`

> ItaniumMangle.cpp:1235
> +      auto FD = dyn_cast<FunctionDecl>(ND);
> +      bool isRegCall = (FD != nullptr) &&
> +        FD->getType()->castAs<FunctionType>()->getCallConv() ==

The convention is to just do `FD` instead of `(FD != nullptr)`

https://reviews.llvm.org/D25204



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to