brad added a comment. Make use of the concat macro with the various header and library paths. https://github.com/llvm/llvm-project/commit/1d0cc510516d50c459f78896a0375fadb13a2b45
================ Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:78 + + if (Output.isFilename()) { + CmdArgs.push_back("-o"); ---------------- Like the other ToolChains this should have before it.. assert((Output.isFilename() || Output.isNothing()) && "Invalid output."); ================ Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:107 + Args.AddAllArgs(CmdArgs, options::OPT_u); + + TC.AddFilePathLibArgs(Args, CmdArgs); ---------------- https://github.com/llvm/llvm-project/commit/894927b491b7c62917ffa7ad665841683095317c ================ Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:119 + Args.AddAllArgs(CmdArgs, options::OPT_t); + Args.AddAllArgs(CmdArgs, options::OPT_r); + ---------------- https://github.com/llvm/llvm-project/commit/894927b491b7c62917ffa7ad665841683095317c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits