rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



> nothrow.cu:16
> +// DEVICE: define void @_Z3foov() [[DEVICE_ATTR:#[0-9]+]]
> +__device__ void foo() { f(); }
> +

I would check for `call void @_Z1fv` here, and make foo noexcept. The noexcept 
is useful because it forces us to essentially emit `try { ... } catch (...) { 
std::terminate(); }` around the whole function, but we probably allow noexcept.

https://reviews.llvm.org/D25166



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to