ZequanWu wrote:

> > Sounds fine to me, but I guess I don't understand why `-profile-correlate=` 
> > doesn't work. Do you still plan to add the flag later?
> 
> I haven't found a way to share information (whether of not binary correlation 
> is enabled) between CodeGen(TargetLoweringObjectFileImpl.cpp) and 
> Instrumentation(InstrProfiling.cpp) components. The explanation is here: 
> https://discourse.llvm.org/t/rfc-add-binary-profile-correlation-to-not-load-profile-metadata-sections-into-memory-at-runtime/74565#use-temporary-section-names-6.

Oh, actually, we can have -profile-correlate flag just need to define it at 
InstrProfCorrelator.cpp (ProfileData component), which is less desired but 
working as discussed at 
https://github.com/llvm/llvm-project/pull/69656#discussion_r1372179620. 

https://github.com/llvm/llvm-project/pull/70856
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to