neoncube2 wrote:

@PiotrZSL Thanks for the quick review! :)

I think #54076 covers the `const` issue. Since `container-data-pointer` is 
already broken for code such as `char *t = str.data();`, I think merging this 
PR wouldn't cause additional issues, but I could be wrong about that! :)

I'd like to take a look at #54076 next, but I think that'd be a bit more 
complicated to fix, since it involves the left-hand side of the expression 
(Unless there's already a helper method to determine whether the left-hand side 
of the expression is `const`?)

Thanks again for the review! :)

https://github.com/llvm/llvm-project/pull/71304
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to