MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:76 + if (!IsStatic || IsStaticPIE) + CmdArgs.push_back("--eh-frame-hdr"); + ---------------- ADKaster wrote: > MaskRay wrote: > > This is not tested > Hm. this also seems like incorrect logic. In my next push I will remove this > condition around --eh-frame-hdr to match the other ToolChains. https://maskray.me/blog/2020-11-08-stack-unwinding I have some notes on ".eh_frame_hdr and PT_GNU_EH_FRAME". > Clang and GCC usually pass --eh-frame-hdr to ld, with the exception that gcc > -static does not pass --eh-frame-hdr. The difference is a historical choice > related to `__register_frame_info`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits