ioeric added inline comments.
================
Comment at: clang-move/ClangMove.cpp:27
+AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass,
+ ast_matchers::internal::Matcher<CXXRecordDecl>, InnerMatcher) {
----------------
I'm not sure if we really need to limit this to the `outer-most` class. In the
future, we might want to support moving nested class, so I guess this can
simply be `ofClass`? Not sure if the name is right though.
================
Comment at: clang-move/ClangMove.cpp:343
// Match static member variable definition of the moved class.
Finder->addMatcher(varDecl(InMovedClass, InOldCC, isDefinition())
.bind("class_static_var_decl"),
----------------
What about static variable of the nested class?
https://reviews.llvm.org/D25369
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
