carlos4242 wrote: The dup in Format seems to have already drifted from the one in Sema so putting them together might be a significant change, a bit more than I'm comfortable taking on... I don't want to break or alter behaviour for someone's formatter just to fix a tiny issue I found in a backwater part of Sema. :)
I'm thinking this probably isn't a testable patch TBH. I came across this issue due to the swift compiler linking into libClang and calling this function. Within clang itself, it looks like it's only used for some obscure objective C case and an equally obscure error case. The only "test" I can envisage is building some kind of artificial stand-alone command line tool that links into libClang and tests it, doesn't seem like a sensible use of anyone's CPU for such a straight bufix? --- But it's a decision for the maintainer....? https://github.com/llvm/llvm-project/pull/72204 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
