koops requested review of this revision. koops added inline comments.
================ Comment at: clang/lib/Basic/CMakeLists.txt:4 TargetParser + FrontendOpenMP ) ---------------- ABataev wrote: > What requires this new dependency? When cmake uses -DBUILD_SHARED_LIBS=1 shared libraries are built instead of archive libraries in lib/ directory. Then, I was getting this error: `Error in linking libclangBasic.so.18git because getOpenMPClauseName() is not defined.` While linking the .o files to form libFrontendOpenMP.so, `OMP.cpp.o` is also included which has the function definition of `getOpenMPClauseName()`. Hence there was a need to have libFrontendOpenMP.so in the link line of libclangBasic.so.18git. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
