arphaman added inline comments.

================
Comment at: lib/Sema/SemaCodeComplete.cpp:3723
     }
   } else if (!IsArrow && BaseType->getAsObjCInterfacePointerType()) {
     // Objective-C property reference.
----------------
manmanren wrote:
> I feel like the added logic belongs to here :] Both handle property reference.
> 
> The clause here handles ObjCObjectPointerType that is based on an 
> ObjCInterfaceType. We need to handle the case where the base type is "id".
> 
> What do you think?
Yes, that makes sense. I updated the patch to handle properties in both the 
interface and qualified IDs in this body of code.


Repository:
  rL LLVM

https://reviews.llvm.org/D25436



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to