phosek added inline comments.

================
Comment at: CMakeLists.txt:327
 # Required flags ==============================================================
 set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build 
dialect")
 add_compile_flags_if_supported(-std=${LIBCXX_STANDARD_VER})
----------------
EricWF wrote:
> Why not just set `LIBCXX_STANDARD_VER` differently instead of replacing it 
> after the fact?
I totally missed it; this change was a part of a downstream patch we were using 
for building Fuchsia toolchain and it predates this option. Using this option, 
I can override the dialect only for our build, which is perfectly fine for 
Fuchsia since we default to C++14. I'd be happy to abandon this patch unless 
you want to persist that setting for musl?


Repository:
  rL LLVM

https://reviews.llvm.org/D25491



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to