ahatanak marked an inline comment as done. ahatanak added a comment. (I'm replying to the comment near TreeTransform.h:11967 because phab doesn't let me hit save)
It looks like RebuildCXXPseudoDestructorExpr isn't even called because a MemberExpr is created instead of a CXXPseudoDestructorExpr. ================ Comment at: lib/Sema/TreeTransform.h:2127 + + if (isa<CXXDestructorDecl>(FoundDecl)) + DNI = getDerived().TransformDeclarationNameInfo(MemberNameInfo); ---------------- rsmith wrote: > I don't see any reason why this should be specific to destructors. But this > is the wrong place for this change; by the time we reach `Rebuild*` we should > have already transformed everything that we need to transform. > > Perhaps the problem is instead... If we want to do the transformation before entering RebuildMemberExpr, I think it's also possible to do it in TreeTransform<Derived>::TransformMemberExpr. https://reviews.llvm.org/D24969 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
