I just committed those tests, so I kinda had to fix them :-P On Wed, Oct 12, 2016 at 5:40 AM, Asiri Rathnayake < asiri.rathnay...@gmail.com> wrote:
> Thanks! > > I still have that no-exception cleanup in my TODO list. Just pressed on > time, hope to get to it soon. > > / Asiri > > On Wed, Oct 12, 2016 at 12:29 PM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ericwf >> Date: Wed Oct 12 06:29:18 2016 >> New Revision: 284005 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=284005&view=rev >> Log: >> Remove incorrect XFAILS >> >> Modified: >> libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.assign/copy.pass.cpp >> libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.assign/move.pass.cpp >> libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.ctor/copy.pass.cpp >> libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.ctor/move.pass.cpp >> >> Modified: libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.assign/copy.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx >> /utilities/optional/optional.object/optional.object.assign/ >> copy.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.assign/copy.pass.cpp (original) >> +++ libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.assign/copy.pass.cpp Wed Oct 12 06:29:18 2016 >> @@ -8,7 +8,6 @@ >> //===------------------------------------------------------ >> ----------------===// >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> -// XFAIL: libcpp-no-exceptions >> // <optional> >> >> // optional<T>& operator=(const optional<T>& rhs); >> @@ -45,7 +44,6 @@ struct Z2 >> Z2& operator=(const Z2&) = default; >> }; >> >> -#if __cplusplus >= 201402 >> template <class T> >> constexpr bool >> test() >> @@ -55,23 +53,18 @@ test() >> opt = opt2; >> return true; >> } >> -#endif >> >> int main() >> { >> { >> using T = int; >> >> static_assert((std::is_trivially_copy_assignable<optional<T>>::value), >> ""); >> -#if __cplusplus >= 201402 >> static_assert(test<T>(), ""); >> -#endif >> } >> { >> using T = X; >> >> static_assert((std::is_trivially_copy_assignable<optional<T>>::value), >> ""); >> -#if __cplusplus >= 201402 >> static_assert(test<T>(), ""); >> -#endif >> } >> static_assert(!(std::is_trivially_copy_assignable<optional<Y>>::value), >> ""); >> >> static_assert(!(std::is_trivially_copy_assignable<optional<std::string>>::value), >> ""); >> >> Modified: libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.assign/move.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx >> /utilities/optional/optional.object/optional.object.assign/ >> move.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.assign/move.pass.cpp (original) >> +++ libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.assign/move.pass.cpp Wed Oct 12 06:29:18 2016 >> @@ -8,7 +8,6 @@ >> //===------------------------------------------------------ >> ----------------===// >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> -// XFAIL: libcpp-no-exceptions >> // <optional> >> >> // optional<T>& operator=(optional<T>&& rhs); >> @@ -42,7 +41,6 @@ struct Z2 >> Z2& operator=(Z2&&) = default; >> }; >> >> -#if __cplusplus >= 201402 >> template <class T> >> constexpr bool >> test() >> @@ -52,23 +50,18 @@ test() >> opt = std::move(opt2); >> return true; >> } >> -#endif >> >> int main() >> { >> { >> using T = int; >> >> static_assert((std::is_trivially_copy_constructible<optional<T>>::value), >> ""); >> -#if __cplusplus >= 201402 >> static_assert(test<T>(), ""); >> -#endif >> } >> { >> using T = X; >> >> static_assert((std::is_trivially_copy_constructible<optional<T>>::value), >> ""); >> -#if __cplusplus >= 201402 >> static_assert(test<T>(), ""); >> -#endif >> } >> static_assert(!(std::is_trivially_move_assignable<optional<Y>>::value), >> ""); >> >> static_assert(!(std::is_trivially_move_assignable<optional<std::string>>::value), >> ""); >> >> Modified: libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.ctor/copy.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx >> /utilities/optional/optional.object/optional.object.ctor/ >> copy.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.ctor/copy.pass.cpp (original) >> +++ libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.ctor/copy.pass.cpp Wed Oct 12 06:29:18 2016 >> @@ -8,7 +8,7 @@ >> //===------------------------------------------------------ >> ----------------===// >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> -// XFAIL: libcpp-no-exceptions >> + >> // <optional> >> >> // optional(const optional<T>& rhs); >> >> Modified: libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.ctor/move.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx >> /utilities/optional/optional.object/optional.object.ctor/ >> move.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.ctor/move.pass.cpp (original) >> +++ libcxx/trunk/test/libcxx/utilities/optional/optional.object/ >> optional.object.ctor/move.pass.cpp Wed Oct 12 06:29:18 2016 >> @@ -8,7 +8,7 @@ >> //===------------------------------------------------------ >> ----------------===// >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> -// XFAIL: libcpp-no-exceptions >> + >> // <optional> >> >> // optional(optional<T>&& rhs); >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
