ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits.
Since `remove_dots` does not delete leading "../" anymore, assertion test need to be updated. https://reviews.llvm.org/D25597 Files: lib/Basic/VirtualFileSystem.cpp Index: lib/Basic/VirtualFileSystem.cpp =================================================================== --- lib/Basic/VirtualFileSystem.cpp +++ lib/Basic/VirtualFileSystem.cpp @@ -1477,8 +1477,9 @@ RedirectingFileSystem::lookupPath(sys::path::const_iterator Start, sys::path::const_iterator End, Entry *From) { #ifndef LLVM_ON_WIN32 - assert(!isTraversalComponent(*Start) && - !isTraversalComponent(From->getName()) && + // FIXME: `remove_dots` does not remove leading "../" anymore, might need + // better test here. + assert(!Start->equals(".") && !isTraversalComponent(From->getName()) && "Paths should not contain traversal components"); #else // FIXME: this is here to support windows, remove it once canonicalized
Index: lib/Basic/VirtualFileSystem.cpp =================================================================== --- lib/Basic/VirtualFileSystem.cpp +++ lib/Basic/VirtualFileSystem.cpp @@ -1477,8 +1477,9 @@ RedirectingFileSystem::lookupPath(sys::path::const_iterator Start, sys::path::const_iterator End, Entry *From) { #ifndef LLVM_ON_WIN32 - assert(!isTraversalComponent(*Start) && - !isTraversalComponent(From->getName()) && + // FIXME: `remove_dots` does not remove leading "../" anymore, might need + // better test here. + assert(!Start->equals(".") && !isTraversalComponent(From->getName()) && "Paths should not contain traversal components"); #else // FIXME: this is here to support windows, remove it once canonicalized
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits