https://github.com/felipepiovezan requested changes to this pull request.

Hi @jeevanghimire, thank you for the PR! I believe the original issue was not 
about changing LLVM test inputs, but rather about changing clang-tidy to warn 
about this kind of patterns. 
Please see my rationale in a previous comment for why we should not be changing 
tests.

For future contributions, I'd also recommend using a more descriptive commit 
title and message. If you inspect the git log of the project, we generally 
follow the pattern:

[some topic] <imperative verb> <short title>

<commit description>


For example, this commit message could have been:

[clang-tidy] Implement "using namespace" check


https://github.com/llvm/llvm-project/pull/74814
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to