Hi Richard, I have a patch on top of your suggested patch from a year ago, that break the cyclic dependency we're seeing, with this (and a few changes to the SDK) we can bootstrap clang with submodule local visibility on darwin. I've attached the patch with a reduced, standalone testcase that doesn't depend on the SDK. The issues that are not covered by your patch, that I cover in mine, are related to built-in and textual headers: they can be found in paths where they don't map to any modules, triggering other cycles. I fix that by looking further to find a matching module for the header in question, instead the first found header in header search.
Can you take a look? Thanks, On Thu, Jul 28, 2016 at 3:55 PM, Adrian Prantl via cfe-commits <cfe-commits@lists.llvm.org> wrote: > +Bruno > > On Jul 27, 2016, at 11:58 PM, Nico Weber <tha...@chromium.org> wrote: > > I played with modules a bit today, and as far as I can tell this is still > broken. If this proves difficult to fix, should this change be reverted for > now? It breaks using modules on Darwin. > > On Sun, Mar 13, 2016 at 12:53 AM, Adrian Prantl via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> > On Mar 11, 2016, at 4:11 PM, Duncan P. N. Exon Smith >> > <dexonsm...@apple.com> wrote: >> > >> > Did anyone file a PR for this? >> > >> >> I filed PR 26928 - Prune the include path for modules >> https://llvm.org/bugs/show_bug.cgi?id=26928 >> as a starting point. >> >> -- adrian >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > -- Bruno Cardoso Lopes http://www.brunocardoso.cc
0001-Add-NoUndeclaredIncludes-attribute-and-logic.patch
Description: Binary data
0002-Changes-on-top-of-Richard-s-patch.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
