Hi Nico, Could you give me more information about the compiler your using?
/Eric On Fri, Oct 14, 2016 at 1:21 PM, Nico Weber <tha...@chromium.org> wrote: > This is breaking tests for me: > > Unexpected Passing Tests (4): > libc++ :: std/language.support/support.dynamic/new.delete/new.delete. > array/new_align_val_t.pass.cpp > libc++ :: std/language.support/support.dynamic/new.delete/new.delete. > array/new_align_val_t_nothrow.pass.cpp > libc++ :: std/language.support/support.dynamic/new.delete/new.delete. > single/new_align_val_t.pass.cpp > libc++ :: std/language.support/support.dynamic/new.delete/new.delete. > single/new_align_val_t_nothrow.pass.cpp > > Am I holding something wrong, or are these XFAILs wrong? > > On Fri, Oct 14, 2016 at 4:47 AM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ericwf >> Date: Fri Oct 14 03:47:09 2016 >> New Revision: 284214 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=284214&view=rev >> Log: >> XFAIL aligned allocation tests for older Clang versions >> >> Modified: >> libcxx/trunk/test/libcxx/test/config.py >> libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t.pass.cpp >> libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_nothrow.pass.cpp >> libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp >> libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_replace.pass.cpp >> libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t.pass.cpp >> libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_nothrow.pass.cpp >> libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp >> libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_replace.pass.cpp >> >> Modified: libcxx/trunk/test/libcxx/test/config.py >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx >> /test/config.py?rev=284214&r1=284213&r2=284214&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/libcxx/test/config.py (original) >> +++ libcxx/trunk/test/libcxx/test/config.py Fri Oct 14 03:47:09 2016 >> @@ -315,6 +315,10 @@ class Configuration(object): >> >> if self.cxx.hasCompileFlag('-faligned-allocation'): >> self.config.available_features.add('-faligned-allocation') >> + else: >> + # FIXME remove this once more than just clang-4.0 support >> + # C++17 aligned allocation. >> + self.config.available_features.add('no-aligned-allocation') >> >> if self.get_lit_bool('has_libatomic', False): >> self.config.available_features.add('libatomic') >> >> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/la >> nguage.support/support.dynamic/new.delete/new.delete.array/ >> new_align_val_t.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t.pass.cpp (original) >> +++ libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t.pass.cpp Fri Oct 14 03:47:09 2016 >> @@ -9,11 +9,13 @@ >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> >> -// test operator new >> - >> // asan and msan will not call the new handler. >> // UNSUPPORTED: sanitizer-new-delete >> >> +// XFAIL: no-aligned-allocation >> + >> +// test operator new >> + >> #include <new> >> #include <cstddef> >> #include <cassert> >> >> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_nothrow.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/la >> nguage.support/support.dynamic/new.delete/new.delete.array/ >> new_align_val_t_nothrow.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_nothrow.pass.cpp (original) >> +++ libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_nothrow.pass.cpp Fri Oct 14 >> 03:47:09 2016 >> @@ -9,11 +9,13 @@ >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> >> -// test operator new (nothrow) >> - >> // asan and msan will not call the new handler. >> // UNSUPPORTED: sanitizer-new-delete >> >> +// XFAIL: no-aligned-allocation >> + >> +// test operator new (nothrow) >> + >> #include <new> >> #include <cstddef> >> #include <cstdint> >> >> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/la >> nguage.support/support.dynamic/new.delete/new.delete.array/ >> new_align_val_t_nothrow_replace.pass.cpp?rev=284214&r1= >> 284213&r2=284214&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp >> (original) >> +++ libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp Fri Oct >> 14 03:47:09 2016 >> @@ -8,10 +8,11 @@ >> //===------------------------------------------------------ >> ----------------===// >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> +// UNSUPPORTED: sanitizer-new-delete >> >> -// test operator new nothrow by replacing only operator new >> +// XFAIL: no-aligned-allocation >> >> -// UNSUPPORTED: sanitizer-new-delete >> +// test operator new nothrow by replacing only operator new >> >> #include <new> >> #include <cstddef> >> @@ -19,7 +20,6 @@ >> #include <cassert> >> #include <limits> >> >> - >> constexpr auto OverAligned = alignof(std::max_align_t) * 2; >> >> int A_constructed = 0; >> >> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_replace.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/la >> nguage.support/support.dynamic/new.delete/new.delete.array/ >> new_align_val_t_replace.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_replace.pass.cpp (original) >> +++ libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.array/new_align_val_t_replace.pass.cpp Fri Oct 14 >> 03:47:09 2016 >> @@ -8,10 +8,11 @@ >> //===------------------------------------------------------ >> ----------------===// >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> +// UNSUPPORTED: sanitizer-new-delete >> >> -// test operator new replacement >> +// XFAIL: no-aligned-allocation >> >> -// UNSUPPORTED: sanitizer-new-delete >> +// test operator new replacement >> >> #include <new> >> #include <cstddef> >> >> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/la >> nguage.support/support.dynamic/new.delete/new.delete.single/ >> new_align_val_t.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t.pass.cpp (original) >> +++ libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t.pass.cpp Fri Oct 14 03:47:09 >> 2016 >> @@ -9,11 +9,13 @@ >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> >> -// test operator new >> - >> // asan and msan will not call the new handler. >> // UNSUPPORTED: sanitizer-new-delete >> >> +// XFAIL: no-aligned-allocation >> + >> +// test operator new >> + >> #include <new> >> #include <cstddef> >> #include <cassert> >> >> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_nothrow.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/la >> nguage.support/support.dynamic/new.delete/new.delete.single/ >> new_align_val_t_nothrow.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_nothrow.pass.cpp (original) >> +++ libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_nothrow.pass.cpp Fri Oct 14 >> 03:47:09 2016 >> @@ -9,11 +9,13 @@ >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> >> -// test operator new (nothrow) >> - >> // asan and msan will not call the new handler. >> // UNSUPPORTED: sanitizer-new-delete >> >> +// XFAIL: no-aligned-allocation >> + >> +// test operator new (nothrow) >> + >> #include <new> >> #include <cstddef> >> #include <cstdint> >> >> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/la >> nguage.support/support.dynamic/new.delete/new.delete.single/ >> new_align_val_t_nothrow_replace.pass.cpp?rev=284214& >> r1=284213&r2=284214&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp >> (original) >> +++ libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp Fri >> Oct 14 03:47:09 2016 >> @@ -8,11 +8,11 @@ >> //===------------------------------------------------------ >> ----------------===// >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> - >> -// test operator new nothrow by replacing only operator new >> - >> // UNSUPPORTED: sanitizer-new-delete >> >> +// XFAIL: no-aligned-allocation >> + >> +// test operator new nothrow by replacing only operator new >> >> #include <new> >> #include <cstddef> >> >> Modified: libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_replace.pass.cpp >> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/la >> nguage.support/support.dynamic/new.delete/new.delete.single/ >> new_align_val_t_replace.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff >> ============================================================ >> ================== >> --- libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_replace.pass.cpp (original) >> +++ libcxx/trunk/test/std/language.support/support.dynamic/new. >> delete/new.delete.single/new_align_val_t_replace.pass.cpp Fri Oct 14 >> 03:47:09 2016 >> @@ -8,10 +8,11 @@ >> //===------------------------------------------------------ >> ----------------===// >> >> // UNSUPPORTED: c++98, c++03, c++11, c++14 >> +// UNSUPPORTED: sanitizer-new-delete >> >> -// test operator new replacement >> +// XFAIL: no-aligned-allocation >> >> -// UNSUPPORTED: sanitizer-new-delete >> +// test operator new replacement >> >> #include <new> >> #include <cstddef> >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits