mclow.lists added inline comments.
================ Comment at: libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp:12 + +// template <class BidirectionalIterator, class Allocator, class charT, class traits> +// bool ---------------- Rather than this comment about `regex_search`, there should be a comment about `match_not_null`, which is really what we're testing here. Something like: // match_not_null: // The expression shall not match an empty sequence. https://reviews.llvm.org/D25595 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits