v.g.vassilev added a subscriber: rsmith. v.g.vassilev added inline comments.
================ Comment at: clang-tidy/utils/UsingInserter.cpp:58 + if (AlreadyHasUsingDecl) { + AddedUsing.emplace(NameInFunction(Function, QualifiedName.str())); + return None; ---------------- bkramer wrote: > v.g.vassilev wrote: > > Using emplace seems to break our modules libstdc++ 4.7 builds: > > http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/6066 > > . Doesn't that break other 4.7 or earlier builds? > GCC 4.7 isn't supported anymore by LLVM (rL284497) can we update that bot to > a newer version of GCC? It is managed by @rsmith . He should be able to tell. https://reviews.llvm.org/D24997 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits