bkramer added a comment. In https://reviews.llvm.org/D25311#574806, @bruno wrote:
> I don't know the history behind the desired dependencies, I'll let others > comment whether this is OK, but my guess it that it depends on the tradeoff, > it's hard to justify 3 new deps for a change that is supposed to be simple. > How hard is to implement this without using libFormat? I think clang already depends on libclangRewrite. libclangToolingCore is tiny, it's basically just the Replacement class and a couple of utilities. While it would be possible to hoist just the include handling and its dependencies out of libclangFormat into a separate library I'm not convinced that it's worth it. libclangFormat is tiny, the .a file is less than a megabyte and the impact on the clang binary is 400kB in a Release+Asserts build, a 0.5% increase. https://reviews.llvm.org/D25311 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
