majnemer added a comment.
You could use `llvm::any_of` instead of `std::any_of`.
================
Comment at: clang/include/clang/Analysis/Analyses/OSLog.h:84-86
+ result |= 0x01;
+ if (getIsPublic())
+ result |= 0x02;
----------------
IsPublic/IsPrivate instead of magic numbers?
================
Comment at: clang/lib/Sema/SemaChecking.cpp:3493
+ Arg = Arg->IgnoreParenCasts();
+ StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
+ if (!Literal) {
----------------
`auto *`
https://reviews.llvm.org/D25888
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
